Hurtful blocks hooks #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- code tidied up & commented as suggested by supermario1313 - removed flag 0x40's initial use as it was deemed superfluous - moved mount safe checks from 0x80 to 0x40 - added gDisableInvisibleHurtBlockBugFix
Contributor
Author
|
ffi_misc.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel like i've tested pretty thoroughly and i feel confident in making a pull request. there is a comment on line 1794 of RuntimeHookHooks.cpp denoting that i fixed a bug that may be considered a compatibility break; blocks marked invisible in the editor are no longer considered for hurting. i changed it because it had bad game feel to me. i can revert that if desired however. i also included my lua edits for some of the configs needed. however i do not know how to implement the bitflag parts and will need sarn to do that.
scripts.zip